Review Request 124856: Call newInstance from the child on first invocation

[David Faure]

> On Aug. 21, 2015, 8:08 a.m., David Faure wrote:
> > I thought the idea was "there's no race, because as long as the recipient doesn't go to the event loop, it won't be processing any incoming messages anyway"?
> 
> Albert Astals Cid wrote:
>     But with Thiago's patches dbus runs in a thread so that's not true anymore.

Why don't Thiago's patches preserve behavior compatibility by starting/enabling the dbus thread only when reaching the event loop?

Otherwise it sounds like any case of "talking to an application that is starting" will create races (am I making the call before or after the object has been published?). Not just KUniqueApplication, but any other dbus call to a starting app, including the dbus activation case.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124856/#review84129
-----------------------------------------------------------


On Aug. 21, 2015, 4:06 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124856/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2015, 4:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Thiago Macieira.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> For the first invocation, call newInstance ourselves instead of relying on the parent process to do it.
> 
> With the new threading patches in qt dbus the current code races as the parent may end up calling newInstance before the child has set up the object that handles it.
> 
> 
> Diffs
> -----
> 
>   src/kdeui/kuniqueapplication.cpp 713c6f4 
>   src/kdeui/kuniqueapplication_p.h de4b328 
> 
> Diff: https://git.reviewboard.kde.org/r/124856/diff/
> 
> 
> Testing
> -------
> 
> konsole starts fine with this + Thiago's Qt dbus threading patches
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150821/4f45fa12/attachment-0001.html>