Review Request 124856: Be a bit stubborn calling newInstance

[Albert Astals Cid]

> On ago. 21, 2015, 8:08 a.m., David Faure wrote:
> > I thought the idea was "there's no race, because as long as the recipient doesn't go to the event loop, it won't be processing any incoming messages anyway"?

But with Thiago's patches dbus runs in a thread so that's not true anymore.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124856/#review84129
-----------------------------------------------------------


On ago. 20, 2015, 11:44 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124856/
> -----------------------------------------------------------
> 
> (Updated ago. 20, 2015, 11:44 p.m.)
> 
> 
> Review request for KDE Frameworks and Thiago Macieira.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> We're calling newInstance from the parent but the child may have not gotten to the point where the application object has been created so the call may fail.
> 
> I don't know why this did not manifest before using Thiago's Qt dbus threading patches but seems the code was racy anyway, should not hurt to have this for Qt's without those patches.
> 
> 
> Diffs
> -----
> 
>   src/kdeui/kuniqueapplication.cpp 713c6f4 
> 
> Diff: https://git.reviewboard.kde.org/r/124856/diff/
> 
> 
> Testing
> -------
> 
> konsole starts fine with this + Thiago's Qt dbus threading patches
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150821/001b96bb/attachment.html>