Review Request 124690: Show custom folder icons again

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Tue Aug 11 18:18:06 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124690/
-----------------------------------------------------------

(Updated Aug. 11, 2015, 6:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, Àlex Fiestas and David Faure.


Changes
-------

Submitted with commit d8aafbc37daab3cd62ee77430a55b3d72ccc12e0 by Emmanuel Pescosta to branch master.


Bugs: 350612
    https://bugs.kde.org/show_bug.cgi?id=350612


Repository: kio


Description
-------

Show custom folder icons again

Set mimetype as known when we assign the mime type for inode/directory

This bug was introduced by commit 46cd152f

BUG: 350612
FIXED-IN: 5.14


Diffs
-----

  autotests/kfileitemtest.h 95612ed 
  autotests/kfileitemtest.cpp 4a87469 
  src/core/kfileitem.cpp 344ac67 

Diff: https://git.reviewboard.kde.org/r/124690/diff/


Testing
-------

KFileItemTest::testIconNameForCustomFolderIcons() fails without the patch but works with the patch.

Folder icons are displayed properly again in Dolphin.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150811/9042d132/attachment.html>


More information about the Kde-frameworks-devel mailing list