Review Request 124690: Show custom folder icons again

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124690/#review83673
-----------------------------------------------------------

Ship it!


Good catch. Just two small issues with the unittest.


autotests/kfileitemtest.cpp (line 479)
<https://git.reviewboard.kde.org/r/124690/#comment57911>

    Well they are now. The comment will be confusing, once this is committed ;)
    I'd say rather something like
        // Custom folder icons should be displayed (bug 350612)



autotests/kfileitemtest.cpp (line 485)
<https://git.reviewboard.kde.org/r/124690/#comment57912>

    should be tempDir.path() rather than url.path() (a URL's path is not a local file path, the confusion creates bugs on Windows)


- David Faure


On Aug. 10, 2015, 6:31 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124690/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 6:31 p.m.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas and David Faure.
> 
> 
> Bugs: 350612
>     https://bugs.kde.org/show_bug.cgi?id=350612
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Show custom folder icons again
> 
> Set mimetype as known when we assign the mime type for inode/directory
> 
> This bug was introduced by commit 46cd152f
> 
> BUG: 350612
> FIXED-IN: 5.14
> 
> 
> Diffs
> -----
> 
>   autotests/kfileitemtest.h 95612ed 
>   autotests/kfileitemtest.cpp 4a87469 
>   src/core/kfileitem.cpp 344ac67 
> 
> Diff: https://git.reviewboard.kde.org/r/124690/diff/
> 
> 
> Testing
> -------
> 
> KFileItemTest::testIconNameForCustomFolderIcons() fails without the patch but works with the patch.
> 
> Folder icons are displayed properly again in Dolphin.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150810/e0b4a36a/attachment.html>