Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

[David Faure]

> On Aug. 6, 2015, 3:10 p.m., Mark Gaiser wrote:
> > src/kconcatenaterowsproxymodel.h, line 58
> > <https://git.reviewboard.kde.org/r/124644/diff/3/?file=390787#file390787line58>
> >
> >     Why do you inherit from QAbstractItemModel? You seem to be making a quite fancy proxy model where multiple source models could be inserted. I would expect an inheritance of QAbstractProxyModel or QSortFilterProxyModel or even QIdentityProxyModel. I think QAbstractProxyModel is the best fit here (which in turn inherits from QAbstractItemModel).
> >     
> >     Just a question, not an issue. If you change it then you mop* functions should probably be documented as reimp though.

The class docu answers this already:

   * This proxy does not inherit from QAbstractProxyModel because it uses multiple source
   * models, rather than a single one.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124644/#review83499
-----------------------------------------------------------


On Aug. 6, 2015, 12:41 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124644/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 12:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> This proxy takes multiple source models and concatenates their rows.
> 
> REVIEW: 124644
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 0cf8fafac60a442ecf8237cc45383cfc7aee79ae 
>   autotests/kconcatenaterowsproxymodeltest.cpp PRE-CREATION 
>   src/CMakeLists.txt fad530d2936a52c80b537aa0e6d22a16928a071d 
>   src/kconcatenaterowsproxymodel.h PRE-CREATION 
>   src/kconcatenaterowsproxymodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124644/diff/
> 
> 
> Testing
> -------
> 
> fully unittested, used in one real app
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150806/b3ab07a1/attachment-0001.html>