Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124644/#review83499
-----------------------------------------------------------



src/kconcatenaterowsproxymodel.h (line 58)
<https://git.reviewboard.kde.org/r/124644/#comment57724>

    Why do you inherit from QAbstractItemModel? You seem to be making a quite fancy proxy model where multiple source models could be inserted. I would expect an inheritance of QAbstractProxyModel or QSortFilterProxyModel or even QIdentityProxyModel. I think QAbstractProxyModel is the best fit here (which in turn inherits from QAbstractItemModel).
    
    Just a question, not an issue. If you change it then you mop* functions should probably be documented as reimp though.



src/kconcatenaterowsproxymodel.h (line 146)
<https://git.reviewboard.kde.org/r/124644/#comment57721>

    Looks like you remembered the smart pointer comment i had with the last model you added :)
    
    Big +1!



src/kconcatenaterowsproxymodel.cpp (line 27)
<https://git.reviewboard.kde.org/r/124644/#comment57722>

    KConcatenateRowsProxyModelPrivate(KConcatenateRowsProxyModel* model)
        : q(model)
        , m_rowCount(0)
    {
    }



src/kconcatenaterowsproxymodel.cpp (lines 50 - 51)
<https://git.reviewboard.kde.org/r/124644/#comment57723>

    "," on the next line, perhaps? This is fine as well if you disagree, but do stay consistent with other class constructors.


- Mark Gaiser


On aug 6, 2015, 12:41 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124644/
> -----------------------------------------------------------
> 
> (Updated aug 6, 2015, 12:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> This proxy takes multiple source models and concatenates their rows.
> 
> REVIEW: 124644
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 0cf8fafac60a442ecf8237cc45383cfc7aee79ae 
>   autotests/kconcatenaterowsproxymodeltest.cpp PRE-CREATION 
>   src/CMakeLists.txt fad530d2936a52c80b537aa0e6d22a16928a071d 
>   src/kconcatenaterowsproxymodel.h PRE-CREATION 
>   src/kconcatenaterowsproxymodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124644/diff/
> 
> 
> Testing
> -------
> 
> fully unittested, used in one real app
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150806/1ad972ae/attachment-0001.html>