Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

[David Faure]

> On Aug. 6, 2015, 12:33 p.m., David Edmundson wrote:
> > src/kconcatenaterowsproxymodel.cpp, line 198
> > <https://git.reviewboard.kde.org/r/124644/diff/2/?file=390783#file390783line198>
> >
> >     potentially if you remove the first sourceModel, the column count has changed too

Well, I had documented that possibility away :)

 * Source models can be added and removed at runtime, including the first source
 * model (but it should keep the same number of columns).

But if someone needs this, it can of course be implemented....


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124644/#review83491
-----------------------------------------------------------


On Aug. 6, 2015, 12:15 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124644/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 12:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> This proxy takes multiple source models and concatenates their rows.
> 
> REVIEW: 124644
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 0cf8fafac60a442ecf8237cc45383cfc7aee79ae 
>   autotests/kconcatenaterowsproxymodeltest.cpp PRE-CREATION 
>   src/CMakeLists.txt fad530d2936a52c80b537aa0e6d22a16928a071d 
>   src/kconcatenaterowsproxymodel.h PRE-CREATION 
>   src/kconcatenaterowsproxymodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124644/diff/
> 
> 
> Testing
> -------
> 
> fully unittested, used in one real app
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150806/f998c5a0/attachment.html>