Review Request 124644: New proxymodel: KConcatenateRowsProxyModel

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124644/#review83491
-----------------------------------------------------------



src/kconcatenaterowsproxymodel.cpp (lines 172 - 175)
<https://git.reviewboard.kde.org/r/124644/#comment57709>

    We don't want to connect to these for the non first model.
    
    This also means reconnecting if the first model changes in removeSourceModel
    
    alternately we could add:
    
    if (sender() != m_models.at(0)) return;
    
    for all column changed slots



src/kconcatenaterowsproxymodel.cpp (line 198)
<https://git.reviewboard.kde.org/r/124644/#comment57711>

    potentially if you remove the first sourceModel, the column count has changed too


- David Edmundson


On Aug. 6, 2015, 12:15 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124644/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 12:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> -------
> 
> This proxy takes multiple source models and concatenates their rows.
> 
> REVIEW: 124644
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 0cf8fafac60a442ecf8237cc45383cfc7aee79ae 
>   autotests/kconcatenaterowsproxymodeltest.cpp PRE-CREATION 
>   src/CMakeLists.txt fad530d2936a52c80b537aa0e6d22a16928a071d 
>   src/kconcatenaterowsproxymodel.h PRE-CREATION 
>   src/kconcatenaterowsproxymodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124644/diff/
> 
> 
> Testing
> -------
> 
> fully unittested, used in one real app
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150806/fd6d9d76/attachment-0001.html>