Review Request 124636: Remove DDS and JPEG-2000 plugin

Alex Merry alex.merry at kde.org
Wed Aug 5 22:27:12 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124636/#review83471
-----------------------------------------------------------

Ship it!


The autotest jp2 images should also be removed (`autotests/read/jp2` and `autotests/write/*.jp2`).

- Alex Merry


On Aug. 5, 2015, 10:11 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124636/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 10:11 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> They were already disabled when building with Qt >= 5.3 in commit
> 3d45b270ea8341d1516d5863cc49884c2744f2f2 because Qt has better plugins
> for those image formats. Now that we depend on Qt 5.3 we can remove
> them.
> 
> 
> Diffs
> -----
> 
>   src/imageformats/CMakeLists.txt 7e75c213586bda8b4e36b39bb9f961e01ed058c0 
>   autotests/CMakeLists.txt 8a2209df3ee267c11d3f6b242767a05c2f86a6c0 
>   README.md c22c8cf2496912236eee29d40b2a6c466c493253 
>   CMakeLists.txt e9915be7de139fea92abfde5d6bac2a45de4745f 
>   src/imageformats/config-jp2.h.cmake 1ef5135ae5e81029000f92228b570154e86d92f3 
>   src/imageformats/dds.cpp bef46b1f840a1b255b61705fea1f47f2a219b270 
>   src/imageformats/dds.desktop 27f0318ca74bf800d9976c469f86ec527d44b02a 
>   src/imageformats/dds.json bc30795640f385230de7ef4b09a7115e53c95ead 
>   src/imageformats/dds_p.h 51c9fd778852623797e718b5f31d331e9c7ad5cb 
>   src/imageformats/jp2.cpp dc9998c4bb6e17517dc98cfd4fa1e3906300454b 
>   src/imageformats/jp2.json 3ff6cde33f4a2906b86ae08a2afb50ce6a3c7fcd 
>   src/imageformats/jp2_p.h 448e847018e00b37a88b4b602adcbb2c22978035 
> 
> Diff: https://git.reviewboard.kde.org/r/124636/diff/
> 
> 
> Testing
> -------
> 
> Successfully built it, ran the tests and installed it.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150805/0779db23/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list