<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124636/">https://git.reviewboard.kde.org/r/124636/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The autotest jp2 images should also be removed (<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">autotests/read/jp2</code> and <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">autotests/write/\*.jp2</code>).</p></pre>
<br />
<p>- Alex Merry</p>
<br />
<p>On August 5th, 2015, 10:11 p.m. UTC, Heiko Becker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Alex Merry.</div>
<div>By Heiko Becker.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2015, 10:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">They were already disabled when building with Qt >= 5.3 in commit
3d45b270ea8341d1516d5863cc49884c2744f2f2 because Qt has better plugins
for those image formats. Now that we depend on Qt 5.3 we can remove
them.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Successfully built it, ran the tests and installed it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/imageformats/CMakeLists.txt <span style="color: grey">(7e75c213586bda8b4e36b39bb9f961e01ed058c0)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(8a2209df3ee267c11d3f6b242767a05c2f86a6c0)</span></li>
<li>README.md <span style="color: grey">(c22c8cf2496912236eee29d40b2a6c466c493253)</span></li>
<li>CMakeLists.txt <span style="color: grey">(e9915be7de139fea92abfde5d6bac2a45de4745f)</span></li>
<li>src/imageformats/config-jp2.h.cmake <span style="color: grey">(1ef5135ae5e81029000f92228b570154e86d92f3)</span></li>
<li>src/imageformats/dds.cpp <span style="color: grey">(bef46b1f840a1b255b61705fea1f47f2a219b270)</span></li>
<li>src/imageformats/dds.desktop <span style="color: grey">(27f0318ca74bf800d9976c469f86ec527d44b02a)</span></li>
<li>src/imageformats/dds.json <span style="color: grey">(bc30795640f385230de7ef4b09a7115e53c95ead)</span></li>
<li>src/imageformats/dds_p.h <span style="color: grey">(51c9fd778852623797e718b5f31d331e9c7ad5cb)</span></li>
<li>src/imageformats/jp2.cpp <span style="color: grey">(dc9998c4bb6e17517dc98cfd4fa1e3906300454b)</span></li>
<li>src/imageformats/jp2.json <span style="color: grey">(3ff6cde33f4a2906b86ae08a2afb50ce6a3c7fcd)</span></li>
<li>src/imageformats/jp2_p.h <span style="color: grey">(448e847018e00b37a88b4b602adcbb2c22978035)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124636/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>