Review Request 123532: Add find modules for ModemManager and NetworkManager

[Jan Grulich]

> On Dub. 28, 2015, 4:09 odp., Lamarque Souza wrote:
> > It worked here, so it's a +1 from me. I just would like the extra-cmake-module maintainer to give the final "ship it".

Hmm, I realized that this would break backward compatibility with plasma-nm, because in plasma-nm we use NETWORKMANAGER_VERSION and not NetworkManager_VERSION. I was trying to use NETWORKMANAGER prefix, but there was a problem with pkg_check_modules, which automatically sets NETWORKMANAGER_VERSION, NETWORKMANAGER_FOUND and NETWORKMANAGER_INCLUDE_DIRS and I couldn't use those variables anymore without using unset(foo) or something else. Any idea how to solve this problem? Is it possible to return two variables in VERSION_VAR?


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123532/#review79633
-----------------------------------------------------------


On Dub. 27, 2015, 2:38 odp., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123532/
> -----------------------------------------------------------
> 
> (Updated Dub. 27, 2015, 2:38 odp.)
> 
> 
> Review request for KDE Frameworks and Lamarque Souza.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This patch adds FindModemManager.cmake and FindNetworkManager.cmake into other find modules. These are required for modemmanager-qt and networkmanager-qt, which are currently missing public dependencies on ModemManager/NetworkManager and to be able to add them, we need to have these find modules publicly available. Note, that my knowledge of CMake is quite limited, so proper review would be needed :).
> 
> 
> Diffs
> -----
> 
>   find-modules/FindModemManager.cmake PRE-CREATION 
>   find-modules/FindNetworkManager.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123532/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150429/7b306317/attachment.html>