Review Request 123532: Add find modules for ModemManager and NetworkManager

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123532/#review79633
-----------------------------------------------------------


It worked here, so it's a +1 from me. I just would like the extra-cmake-module maintainer to give the final "ship it".

- Lamarque Souza


On April 27, 2015, 2:38 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123532/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 2:38 p.m.)
> 
> 
> Review request for KDE Frameworks and Lamarque Souza.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> This patch adds FindModemManager.cmake and FindNetworkManager.cmake into other find modules. These are required for modemmanager-qt and networkmanager-qt, which are currently missing public dependencies on ModemManager/NetworkManager and to be able to add them, we need to have these find modules publicly available. Note, that my knowledge of CMake is quite limited, so proper review would be needed :).
> 
> 
> Diffs
> -----
> 
>   find-modules/FindModemManager.cmake PRE-CREATION 
>   find-modules/FindNetworkManager.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123532/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150428/2a0cb326/attachment.html>