Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

[Aleix Pol Gonzalez]

> On April 25, 2015, 3:50 a.m., Matthew Dawson wrote:
> > autotests/kconfig_compiler/test13.h.ref, line 55
> > <https://git.reviewboard.kde.org/r/123367/diff/9/?file=363036#file363036line55>
> >
> >     Also, I guess brightnessChanged and usrWriteconfig don't need to be generated anymore if a signal isn't being produced.
> >     
> >     Considering how much time this has taken, I'd be ok leaving the brightnessChanged signal alone for this review, and removing it later.

I don't understand what you mean. They need to be generated so that we know when it changes on a different instance. In fact, what would we win by not generating them?
Or you mean we don't actually need to create the Changed signal, just trigger the modified when it's due?

I thought it was ok having both signals, maybe I was in the wrong, but we need to decide whether to get it in in this patch as it produces source incompatible code. (a signal less)


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79483
-----------------------------------------------------------


On April 25, 2015, 3:39 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123367/
> -----------------------------------------------------------
> 
> (Updated April 25, 2015, 3:39 a.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> The generation of those classes makes it useful to have these being used within C++ application. This change makes it possible to use these classes from QML as well.
> 
> For each variable, exposes the getter. In case there's a setter, it will add a notify signal and the setter to the property.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfig_compiler/CMakeLists.txt 0cca605 
>   autotests/kconfig_compiler/kconfigcompiler_test.cpp 43623ce 
>   autotests/kconfig_compiler/test13.cpp.ref PRE-CREATION 
>   autotests/kconfig_compiler/test13.h.ref PRE-CREATION 
>   autotests/kconfig_compiler/test13.kcfg PRE-CREATION 
>   autotests/kconfig_compiler/test13.kcfgc PRE-CREATION 
>   autotests/kconfig_compiler/test13main.cpp PRE-CREATION 
>   autotests/kconfig_compiler/test_signal.cpp.ref 58e73ef 
>   autotests/kconfig_compiler/test_signal.h.ref 19b8b40 
>   src/kconfig_compiler/kconfig_compiler.cpp 5aae340 
> 
> Diff: https://git.reviewboard.kde.org/r/123367/diff/
> 
> 
> Testing
> -------
> 
> KConfig tests still pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150425/b7b72b16/attachment.html>