Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

[Matthew Dawson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79483
-----------------------------------------------------------


Ok, I think this should be last set of comments.  One thing I missed, and one last thought I had looking at what the final diff looks like.


autotests/kconfig_compiler/test13.h.ref (line 36)
<https://git.reviewboard.kde.org/r/123367/#comment54313>

    Sorry, I missed this change.  This also needs to emit brightnessModified (while also change mSettingChanged if brightnessChanged is created).



autotests/kconfig_compiler/test13.h.ref (line 55)
<https://git.reviewboard.kde.org/r/123367/#comment54314>

    Also, I guess brightnessChanged and usrWriteconfig don't need to be generated anymore if a signal isn't being produced.
    
    Considering how much time this has taken, I'd be ok leaving the brightnessChanged signal alone for this review, and removing it later.


- Matthew Dawson


On April 24, 2015, 9:39 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123367/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 9:39 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> The generation of those classes makes it useful to have these being used within C++ application. This change makes it possible to use these classes from QML as well.
> 
> For each variable, exposes the getter. In case there's a setter, it will add a notify signal and the setter to the property.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfig_compiler/CMakeLists.txt 0cca605 
>   autotests/kconfig_compiler/kconfigcompiler_test.cpp 43623ce 
>   autotests/kconfig_compiler/test13.cpp.ref PRE-CREATION 
>   autotests/kconfig_compiler/test13.h.ref PRE-CREATION 
>   autotests/kconfig_compiler/test13.kcfg PRE-CREATION 
>   autotests/kconfig_compiler/test13.kcfgc PRE-CREATION 
>   autotests/kconfig_compiler/test13main.cpp PRE-CREATION 
>   autotests/kconfig_compiler/test_signal.cpp.ref 58e73ef 
>   autotests/kconfig_compiler/test_signal.h.ref 19b8b40 
>   src/kconfig_compiler/kconfig_compiler.cpp 5aae340 
> 
> Diff: https://git.reviewboard.kde.org/r/123367/diff/
> 
> 
> Testing
> -------
> 
> KConfig tests still pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150425/4f769958/attachment.html>