Review Request 123491: Add a test that checks the modules we're depending on exist

[Alex Merry]

> On April 24, 2015, 3:36 p.m., Alex Merry wrote:
> > modules/ECMGeneratePriFile.cmake, lines 178-180
> > <https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line178>
> >
> >     I think there should be an argument that could be passed to disable this (NO_TESTS?). Not all downstream users may want such a test.
> 
> Albert Astals Cid wrote:
>     Why wouldn't you want a test that checks that your .pri is not broken?
> 
> Alex Merry wrote:
>     Projects may have policies about tests that this doesn't satisfy. It could be that the test would fail in valid build environments (although I'll admit it's unlikely you would have a dependency needed for users of a project but not for the project itself). There could be other reasons I can't forsee.

Also, see the issue Kevin raised about Sonnet. We may fix that particular case, but there could be others like it that we don't spot. The test isn't required for the module to do its job, so I'd rather it not be enforced.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123491/#review79458
-----------------------------------------------------------


On April 24, 2015, 3:26 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123491/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 3:26 p.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and Kevin Funk.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Do some sanity checking on the dependencies we're declaring
> 
> 
> Diffs
> -----
> 
>   modules/ECMGeneratePriFile.cmake af4b877 
> 
> Diff: https://git.reviewboard.kde.org/r/123491/diff/
> 
> 
> Testing
> -------
> 
> Ran make test in ktextwidgets without http://quickgit.kde.org/?p=ktextwidgets.git&a=commitdiff&h=b83617d59b14941b1e26d295e9ea300301365321 and it correctly failed.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150424/7ad04e80/attachment.html>