Review Request 123491: Add a test that checks the modules we're depending on exist

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123491/#review79460
-----------------------------------------------------------



modules/ECMGeneratePriFile.cmake (line 179)
<https://git.reviewboard.kde.org/r/123491/#comment54303>

    Just tested the patch myself on sonnet.
    
    The test indeed breaks if sonnet is not installed beforehand. But I agree, that's probably not a big issue since we usually have to install before running `make test`.
    
    Not having the right `QMAKEPATH` set during the test run imposes another burden on the user, however.
    
    What about adding:
    ```
    set_tests_properties(... PROPERTIES
      ENVIRONMENT
        QMAKEPATH=${qt_host_data_dir}
    ```


- Kevin Funk


On April 24, 2015, 3:26 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123491/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 3:26 p.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and Kevin Funk.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Do some sanity checking on the dependencies we're declaring
> 
> 
> Diffs
> -----
> 
>   modules/ECMGeneratePriFile.cmake af4b877 
> 
> Diff: https://git.reviewboard.kde.org/r/123491/diff/
> 
> 
> Testing
> -------
> 
> Ran make test in ktextwidgets without http://quickgit.kde.org/?p=ktextwidgets.git&a=commitdiff&h=b83617d59b14941b1e26d295e9ea300301365321 and it correctly failed.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150424/846fd9ba/attachment.html>