Review Request 123421: [KNewStuff] Use KDE_INSTALL_DATADIR_KF5 instead of DATA_INSTALL_DIR for future co-installability

Hrvoje Senjan hrvoje.senjan at gmail.com
Sun Apr 19 01:28:14 UTC 2015



> On April 18, 2015, 11:29 p.m., Gregor Mi wrote:
> > Ship It!
> 
> Gregor Mi wrote:
>     Thanks for also taking care of the commments/documentation. There is some more, which I will do later.

Ok, founds some other references to old location and adjusted them also.
Please check the commit message: if other apps are to install files into this dir, then a better solution would be to have
KDE_INSTALL_KMORETOOLS5DIR which would expand to DATAROOTDIR/kmoretools5.
For this we have time until 5.10.0 is relased and location becomes a part of the public API.


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123421/#review79182
-----------------------------------------------------------


On April 19, 2015, 3:24 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123421/
> -----------------------------------------------------------
> 
> (Updated April 19, 2015, 3:24 a.m.)
> 
> 
> Review request for KDE Frameworks, Gregor Mi and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Like it's done with the rest of the frameworks.
> 
> 
> Diffs
> -----
> 
>   data/CMakeLists.txt 32d39ab 
>   src/kmoretools/kmoretools.h 89e75b5 
>   src/kmoretools/kmoretools.cpp 27a0f74 
> 
> Diff: https://git.reviewboard.kde.org/r/123421/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150419/0f0b2b33/attachment.html>


More information about the Kde-frameworks-devel mailing list