Review Request 123421: [KNewStuff] Use KDE_INSTALL_DATADIR_KF5 instead of DATA_INSTALL_DIR for future co-installability

Gregor Mi codestruct at posteo.org
Sat Apr 18 23:09:59 UTC 2015



> On April 18, 2015, 9:29 p.m., Gregor Mi wrote:
> > Ship It!

Thanks for also taking care of the commments/documentation. There is some more, which I will do later.


- Gregor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123421/#review79182
-----------------------------------------------------------


On April 18, 2015, 7:45 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123421/
> -----------------------------------------------------------
> 
> (Updated April 18, 2015, 7:45 p.m.)
> 
> 
> Review request for KDE Frameworks, Gregor Mi and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> Like it's done with the rest of the frameworks.
> 
> 
> Diffs
> -----
> 
>   data/CMakeLists.txt 32d39ab 
>   src/kmoretools/kmoretools.h 89e75b5 
>   src/kmoretools/kmoretools.cpp 27a0f74 
> 
> Diff: https://git.reviewboard.kde.org/r/123421/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150418/350229a0/attachment.html>


More information about the Kde-frameworks-devel mailing list