Review Request 123348: NetworkManagerQt: fix the building of the examples, and the installed headers.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123348/
-----------------------------------------------------------

(Updated April 17, 2015, 12:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Jan Grulich.


Changes
-------

Submitted with commit 99668971cc1c33712ac088a6a05101d0a9c09253 by David Faure to branch master.


Repository: networkmanager-qt


Description
-------

The examples didn't build because <NetworkManagerQt/Manager> didn't exist
locally in the builddir. Using ecm_generate_headers properly for such a namespaced
framework (i.e. with PREFIX, like KParts does) fixes that, and makes the installation
of the headers more standard:
NetworkManagerQt/Manager and networkmanagerqt/manager.h, all lowercase;
both only available if linking to KF5::NetworkManagerQt.

This will break users of <NetworkManagerQt/manager.h> though (camelcase/lowercase mix),
if there are any.


Diffs
-----

  src/CMakeLists.txt d59949bd2264b1e10de3bc4fedb9e50b8c88f1f3 

Diff: https://git.reviewboard.kde.org/r/123348/diff/


Testing
-------

Compiled examples, ran make install and checked destination paths, rebuilt plasma-nm succesfully.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150417/d8072bbd/attachment.html>