Review Request 123348: NetworkManagerQt: fix the building of the examples, and the installed headers.
Lamarque Souza
lamarque at kde.org
Sun Apr 12 22:03:41 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123348/#review78876
-----------------------------------------------------------
Ship it!
Ship It!
- Lamarque Souza
On April 12, 2015, 7:51 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123348/
> -----------------------------------------------------------
>
> (Updated April 12, 2015, 7:51 p.m.)
>
>
> Review request for KDE Frameworks and Jan Grulich.
>
>
> Repository: networkmanager-qt
>
>
> Description
> -------
>
> The examples didn't build because <NetworkManagerQt/Manager> didn't exist
> locally in the builddir. Using ecm_generate_headers properly for such a namespaced
> framework (i.e. with PREFIX, like KParts does) fixes that, and makes the installation
> of the headers more standard:
> NetworkManagerQt/Manager and networkmanagerqt/manager.h, all lowercase;
> both only available if linking to KF5::NetworkManagerQt.
>
> This will break users of <NetworkManagerQt/manager.h> though (camelcase/lowercase mix),
> if there are any.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt d59949bd2264b1e10de3bc4fedb9e50b8c88f1f3
>
> Diff: https://git.reviewboard.kde.org/r/123348/diff/
>
>
> Testing
> -------
>
> Compiled examples, ran make install and checked destination paths, rebuilt plasma-nm succesfully.
>
>
> Thanks,
>
> David Faure
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150412/d3a98f2f/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list