Review Request 123360: Introduce LoopSound flag

Martin Klapetek martin.klapetek at gmail.com
Wed Apr 15 11:21:17 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123360/
-----------------------------------------------------------

(Updated April 15, 2015, 11:21 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 5281dbec2188c29f3e236f54cbd24fd26d171365 by Martin Klapetek to branch master.


Bugs: 346148
    https://bugs.kde.org/show_bug.cgi?id=346148


Repository: knotifications


Description
-------

Some notifications might want to loop the sound, eg. calling apps playing the ringing sound which is not wanted to play once. Currently the sound is looped for all persistent notifications, but that's not ideal as not all persistent notifications with sound want/need sound looping. This new LoopSound flag solves that.


Diffs
-----

  src/knotification.h 8efd92a 
  src/notifybyaudio.cpp ee3ef1e 

Diff: https://git.reviewboard.kde.org/r/123360/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150415/04b9e439/attachment.html>


More information about the Kde-frameworks-devel mailing list