Review Request 123360: Introduce LoopSound flag

Lamarque Souza lamarque at kde.org
Wed Apr 15 01:43:54 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123360/#review78950
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza


On April 14, 2015, 2:41 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123360/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 2:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 346148
>     https://bugs.kde.org/show_bug.cgi?id=346148
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Some notifications might want to loop the sound, eg. calling apps playing the ringing sound which is not wanted to play once. Currently the sound is looped for all persistent notifications, but that's not ideal as not all persistent notifications with sound want/need sound looping. This new LoopSound flag solves that.
> 
> 
> Diffs
> -----
> 
>   src/knotification.h 8efd92a 
>   src/notifybyaudio.cpp ee3ef1e 
> 
> Diff: https://git.reviewboard.kde.org/r/123360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150415/6bf6a46d/attachment.html>


More information about the Kde-frameworks-devel mailing list