Review Request 123329: Don't crash if notification has no widget and notification is set to notify by taskbar

[David Edmundson]

> On April 11, 2015, 1 p.m., Aleix Pol Gonzalez wrote:
> > src/notifybytaskbar.cpp, line 46
> > <https://git.reviewboard.kde.org/r/123329/diff/1/?file=360783#file360783line46>
> >
> >     won't this need finish(notification);?

Oh, so it should. Thanks.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123329/#review78809
-----------------------------------------------------------


On April 11, 2015, 12:22 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123329/
> -----------------------------------------------------------
> 
> (Updated April 11, 2015, 12:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Don't crash if notification has no widget and notification is set to notify by taskbar
> 
> 
> Diffs
> -----
> 
>   src/notifybytaskbar.cpp 72d01af 
> 
> Diff: https://git.reviewboard.kde.org/r/123329/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150411/ba845972/attachment.html>