Review Request 123329: Don't crash if notification has no widget and notification is set to notify by taskbar
Aleix Pol Gonzalez
aleixpol at kde.org
Sat Apr 11 13:00:48 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123329/#review78809
-----------------------------------------------------------
src/notifybytaskbar.cpp (line 46)
<https://git.reviewboard.kde.org/r/123329/#comment53912>
won't this need finish(notification);?
- Aleix Pol Gonzalez
On April 11, 2015, 2:22 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123329/
> -----------------------------------------------------------
>
> (Updated April 11, 2015, 2:22 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> Don't crash if notification has no widget and notification is set to notify by taskbar
>
>
> Diffs
> -----
>
> src/notifybytaskbar.cpp 72d01af
>
> Diff: https://git.reviewboard.kde.org/r/123329/diff/
>
>
> Testing
> -------
>
> Builds
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150411/5a777d9f/attachment.html>
More information about the Kde-frameworks-devel
mailing list