Review Request 123206: Don't try to highlight if there is no spell checker found

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123206/#review78722
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Tobias Holmedahl Sandsmark


On April 1, 2015, 11:46 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123206/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 11:46 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: sonnet
> 
> 
> Description
> -------
> 
> Don't try to highlight if there is no spell checker found
> 
> It's slightly wasteful to do a re-highlight, more important without this we max out the CPU usage as rehighlightRequest singleShot is still false (see line 120 in the constructor), so this timer constantly retriggers with no interval.
> 
> 
> Diffs
> -----
> 
>   src/ui/highlighter.cpp 05c72ec 
> 
> Diff: https://git.reviewboard.kde.org/r/123206/diff/
> 
> 
> Testing
> -------
> 
> ran textedit example without my CPU usage skyrocketing.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150409/819b11c0/attachment.html>