Review Request 123206: Don't try to highlight if there is no spell checker found

David Edmundson david at davidedmundson.co.uk
Wed Apr 1 11:46:07 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123206/
-----------------------------------------------------------

Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Repository: sonnet


Description
-------

Don't try to highlight if there is no spell checker found

It's slightly wasteful to do a re-highlight, more important without this we max out the CPU usage as rehighlightRequest singleShot is still false (see line 120 in the constructor), so this timer constantly retriggers with no interval.


Diffs
-----

  src/ui/highlighter.cpp 05c72ec 

Diff: https://git.reviewboard.kde.org/r/123206/diff/


Testing
-------

ran textedit example without my CPU usage skyrocketing.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150401/87086bd4/attachment.html>


More information about the Kde-frameworks-devel mailing list