Review Request 120408: Port textcreator thumbnailer

Maarten De Meyer de.meyer.maarten at gmail.com
Mon Sep 29 19:42:56 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120408/
-----------------------------------------------------------

(Updated Sept. 29, 2014, 7:42 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kio-extras


Description
-------

Quick port. I left the kencodingprober code for now. Maybe we should just drop it? Or fix kencodingprober.
thumbcreator needs to be a QGuiApplication because we use pixmaps.


Diffs
-----

  thumbnail/thumbnail.cpp 3a38dc9 
  thumbnail/textcreator.cpp d3f633c 
  thumbnail/CMakeLists.txt aec8b8e 

Diff: https://git.reviewboard.kde.org/r/120408/diff/


Testing
-------

Text thumbnails work.
Utf8 files show with the correct encoding.


Thanks,

Maarten De Meyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140929/2df1e62d/attachment.html>


More information about the Kde-frameworks-devel mailing list