Review Request 120812: Allow setDefaultShortcuts() to be invoked via QMetaObject

Christoph Feck christoph at maxiom.de
Mon Oct 27 21:21:36 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120812/
-----------------------------------------------------------

(Updated Oct. 27, 2014, 9:21 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kxmlgui


Description
-------

While porting KCharSelect application to KF5, I noticed that KCharSelect widget class still uses QAction::setShortcuts() instead of KActionCollection::setDefaultShortcuts().

This adds Q_INVOKABLE to setDefaultShortcuts() - same as for addAction() - so that KCharSelect widget class does not need to depend on kxmlgui.

For the KCharSelect patch see https://git.reviewboard.kde.org/r/120813/


Diffs
-----

  src/kactioncollection.h 243ef09 

Diff: https://git.reviewboard.kde.org/r/120812/diff/


Testing
-------

None, I have to wait until buildservice picks it up :P


Thanks,

Christoph Feck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141027/057b14b0/attachment.html>


More information about the Kde-frameworks-devel mailing list