Review Request 120812: Allow setDefaultShortcuts() to be invoked via QMetaObject

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120812/#review69161
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Oct. 26, 2014, 2:23 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120812/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2014, 2:23 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> While porting KCharSelect application to KF5, I noticed that KCharSelect widget class still uses QAction::setShortcuts() instead of KActionCollection::setDefaultShortcuts().
> 
> This adds Q_INVOKABLE to setDefaultShortcuts() - same as for addAction() - so that KCharSelect widget class does not need to depend on kxmlgui.
> 
> For the KCharSelect patch see https://git.reviewboard.kde.org/r/120813/
> 
> 
> Diffs
> -----
> 
>   src/kactioncollection.h 243ef09 
> 
> Diff: https://git.reviewboard.kde.org/r/120812/diff/
> 
> 
> Testing
> -------
> 
> None, I have to wait until buildservice picks it up :P
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141026/a0bacac9/attachment.html>