Review Request 120605: cleanup overlay icon usage

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120605/#review68731
-----------------------------------------------------------

Ship it!


I think the idea of the .gz overlay was for more specific files like foo.txt.gz, postscript.ppd.gz, appdata.xml.gz

But indeed meanwhile many others of these got their own mimetype (*.pcf.gz is application/x-font-pcf, *.pdf.gz is application/x-gzpdf....) so it's hard to find out when an overlay should be added and when it shouldn't.

And the overlay idea only works if the main icon doesn't take the ".gz" into account... seems this got lost somewhen.
Not worth our time, go ahead.

- David Faure


On Oct. 16, 2014, 3:32 p.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120605/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 3:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 339193
>     https://bugs.kde.org/show_bug.cgi?id=339193
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> The locked overlay should be added also for directories, as there is no
> distinct "unreadable directory" icon.
> No overlay icon for "gzip files with .gz file ending", there is a
> mimetype icon for gzip files.
> 
> BUGS: 339193
> 
> Signed-off-by: Stefan Brüns <stefan.bruens at rwth-aachen.de>
> 
> 
> Diffs
> -----
> 
>   src/core/kfileitem.cpp 74dc069dc964f4fb0040a3dab916ff0d1e26602c 
> 
> Diff: https://git.reviewboard.kde.org/r/120605/diff/
> 
> 
> Testing
> -------
> 
> Patched kio, see BR for new screenshot
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141019/ef313057/attachment.html>