Review Request 120605: cleanup overlay icon usage

[Emmanuel Pescosta]

> On Oct. 16, 2014, 8:09 p.m., Emmanuel Pescosta wrote:
> > Looks good! +1 from my side
> > 
> > (Please use the CCBUG hook when you commit this patch, because it only fixes one mentioned problem)
> 
> Stefan Brüns wrote:
>     Any more comments? Is this a SHIP IT?
>     
>     BTW: The same applies to SC 4, should I backport it to 4.14?

> Any more comments? Is this a SHIP IT?

The KIO maintainer (dfaure) will give you a ship it.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120605/#review68567
-----------------------------------------------------------


On Oct. 16, 2014, 5:32 p.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120605/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 5:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 339193
>     https://bugs.kde.org/show_bug.cgi?id=339193
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> The locked overlay should be added also for directories, as there is no
> distinct "unreadable directory" icon.
> No overlay icon for "gzip files with .gz file ending", there is a
> mimetype icon for gzip files.
> 
> BUGS: 339193
> 
> Signed-off-by: Stefan Brüns <stefan.bruens at rwth-aachen.de>
> 
> 
> Diffs
> -----
> 
>   src/core/kfileitem.cpp 74dc069dc964f4fb0040a3dab916ff0d1e26602c 
> 
> Diff: https://git.reviewboard.kde.org/r/120605/diff/
> 
> 
> Testing
> -------
> 
> Patched kio, see BR for new screenshot
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141019/4ccc3596/attachment.html>