Review Request 120443: Add ctags configuration option to highlighting

Christoph Cullmann cullmann at kde.org
Fri Oct 10 19:55:42 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120443/#review68224
-----------------------------------------------------------


Hi, I think that should not be in KTextEditor.
Thats really special and given that only a very limited amount of languages with ctags specials exists, it would make more sense to just have a heuristic in the project plugin to figure that out on its own.

- Christoph Cullmann


On Sept. 30, 2014, 8:34 p.m., Bastian Holst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120443/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 8:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> Add ctags configuration option to highlighting
> 
> I need the added function to ask for the ctags command from kate's project plugin. I am still not sure if this is the right place to add the function. What do you think?
> 
> 
> Diffs
> -----
> 
>   src/document/katedocument.cpp 82363ed73bac515918b99d935cfc53d667bde3f7 
>   src/include/ktexteditor/mainwindow.h bfee68a6536282d4ac58fc6adf16349b0d514d0b 
>   src/mode/katemodemanager.h e249913483cd184e9c66066bc49907fd49325a9d 
>   src/mode/katemodemanager.cpp 694ca6219c80b8812f86912e58f3c14fe9324f92 
>   src/syntax/data/haskell.xml f0e7f8f955ea9cd56795add8de03c6627313301a 
>   src/syntax/data/katehighlightingindexer.cpp 3f02e8c2a76e471489bc6df2a9f4ac0463c3afe0 
>   src/syntax/data/language.xsd 3f20304efe9c7a29df0dbe0a822196ec612437e8 
>   src/syntax/data/literate-haskell.xml f69dbc56d7effbfa02398456cea616f0fce2d706 
>   src/syntax/katehighlight.h 237cf1a1837a4cf7d530be5a6a74ba9df7d0f8b7 
>   src/syntax/katesyntaxmanager.h 94c2b597cb0935feea01e454ba92eddc24be7af6 
>   src/syntax/katesyntaxmanager.cpp c51fbaf9eb230dfd1fb1602000860bf21a5cd8ce 
>   src/utils/mainwindow.cpp 6e664a9e7d0d9301ef12d9b1d7050fa2e3007d6f 
> 
> Diff: https://git.reviewboard.kde.org/r/120443/diff/
> 
> 
> Testing
> -------
> 
> Testing with modified version of Kates project plugin (https://git.reviewboard.kde.org/r/120444/).
> 
> 
> Thanks,
> 
> Bastian Holst
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141010/209bd634/attachment.html>


More information about the Kde-frameworks-devel mailing list