Review Request 120539: Fix incorrect count of netwm atoms

Martin Gräßlin mgraesslin at kde.org
Fri Oct 10 15:06:58 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120539/
-----------------------------------------------------------

(Updated Oct. 10, 2014, 3:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and kwin.


Bugs: 339771
    https://bugs.kde.org/show_bug.cgi?id=339771


Repository: kwindowsystem


Description
-------

This fixes a regression introduced with
59cb063b99e6ec13c0bc3cf3fd95a01258184e86.

The commit added 4 new atoms but only incremented the atom count by 3.
Which can cause a crash as soon as the NET classes are used.

To ensure that such an error is not introduced again, an assert is
added.

BUG: 339771


Diffs
-----

  src/netwm.cpp 3107a2388c2fb3f1a8ad97e466be40e6977e064b 

Diff: https://git.reviewboard.kde.org/r/120539/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141010/b6e6b033/attachment.html>


More information about the Kde-frameworks-devel mailing list