Review Request 120539: Fix incorrect count of netwm atoms

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120539/#review68114
-----------------------------------------------------------

Ship it!


Alternatively, the count could be set at runtime (either accessed dynamically or set to a non const global)
Or try to fail building time:
http://scaryreasoner.wordpress.com/2009/02/28/checking-sizeof-at-compile-time/
(but that needs to be tested with the clang preproc, I assume)

- Thomas Lübking


On Okt. 9, 2014, 9:11 vorm., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120539/
> -----------------------------------------------------------
> 
> (Updated Okt. 9, 2014, 9:11 vorm.)
> 
> 
> Review request for KDE Frameworks and kwin.
> 
> 
> Bugs: 339771
>     https://bugs.kde.org/show_bug.cgi?id=339771
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> This fixes a regression introduced with
> 59cb063b99e6ec13c0bc3cf3fd95a01258184e86.
> 
> The commit added 4 new atoms but only incremented the atom count by 3.
> Which can cause a crash as soon as the NET classes are used.
> 
> To ensure that such an error is not introduced again, an assert is
> added.
> 
> BUG: 339771
> 
> 
> Diffs
> -----
> 
>   src/netwm.cpp 3107a2388c2fb3f1a8ad97e466be40e6977e064b 
> 
> Diff: https://git.reviewboard.kde.org/r/120539/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141009/da9a9b43/attachment.html>