Review Request 120099: RFC: UI-Files inside resources instead of filesystem

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120099/#review67966
-----------------------------------------------------------


Sorry for chiming in late, just noticed the commit.

Any reason why the resource is checked first, not last?

If the programmer decides to use the resource, the "locateAll" effectively turns into a "locateNone". Not really friendly to administrators.

- Christoph Feck


On Oct. 5, 2014, 5:32 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120099/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2014, 5:32 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Instead of installing them in the kxmlgui5 share prefix, install them in a kxmlgui5 prefix in resources.
> That will allow to test stuff without installing it first, as the resources will be found anyway.
> Still the "I can edit it and have a copy in my writable datadir" should work.
> Question is: is it possible with one "kxmlgui" prefix for the resource or is it better to swap that around like "componentname/kxmlgui5/.."?
> 
> 
> Diffs
> -----
> 
>   src/kxmlguiclient.cpp e8170ad 
>   src/kxmlguifactory.cpp c4ad97b 
> 
> Diff: https://git.reviewboard.kde.org/r/120099/diff/
> 
> 
> Testing
> -------
> 
> Compiles & if I package ui file in kate into resource, works.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141005/d48974d7/attachment.html>