Review Request 120267: Don't run kioexec if we are already running it

[Maarten De Meyer]

> On Oct. 3, 2014, 8:49 p.m., David Faure wrote:
> > no vacations, rather extremely busy, with DevDays preparations :)
> > 
> > I saw this patch, but the hardcoded "dummy" looks strange, where does that service name even come from? I don't see any instance of it in kio/src/core nor kservice...
> > There must be a better way of doing this...

It's the service name kioexec runs as. I agree dummy is confusing, Ihave now changed it to 'kioexec'
Do you think this will break things?
Or do you know of a better way that doen't use the name?


- Maarten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120267/#review67874
-----------------------------------------------------------


On Oct. 4, 2014, 12:56 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120267/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2014, 12:56 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 339123
>     https://bugs.kde.org/show_bug.cgi?id=339123
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Only add the actual command and url's otherwise we keep spawning instances of kioexec.
> Maybe we should rename the kioexec service from 'dummy' to 'kioexec-dummy' just to be safe.
> 
> 
> Diffs
> -----
> 
>   src/core/desktopexecparser.cpp 9510697 
>   src/kioexec/main.cpp f0e2823 
> 
> Diff: https://git.reviewboard.kde.org/r/120267/diff/
> 
> 
> Testing
> -------
> 
> Run kioexec with local file from command line.
> Remote files don't work (before and after) I'll take a look at that next.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141004/a061ccb4/attachment.html>