Review Request 120267: Don't run kioexec if we are already running it

Maarten De Meyer de.meyer.maarten at gmail.com
Sat Oct 4 12:56:17 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120267/
-----------------------------------------------------------

(Updated Oct. 4, 2014, 12:56 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Change service name to kioexec


Bugs: 339123
    https://bugs.kde.org/show_bug.cgi?id=339123


Repository: kio


Description
-------

Only add the actual command and url's otherwise we keep spawning instances of kioexec.
Maybe we should rename the kioexec service from 'dummy' to 'kioexec-dummy' just to be safe.


Diffs (updated)
-----

  src/core/desktopexecparser.cpp 9510697 
  src/kioexec/main.cpp f0e2823 

Diff: https://git.reviewboard.kde.org/r/120267/diff/


Testing
-------

Run kioexec with local file from command line.
Remote files don't work (before and after) I'll take a look at that next.


Thanks,

Maarten De Meyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141004/ca00c87a/attachment.html>


More information about the Kde-frameworks-devel mailing list