Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

Christoph Feck christoph at maxiom.de
Tue Nov 18 09:07:03 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121145/#review70575
-----------------------------------------------------------

Ship it!


Ship It!

- Christoph Feck


On Nov. 17, 2014, 4:48 p.m., Laurent Montel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121145/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 4:48 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck and David Faure.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> This new widget adds a button on splitter to collapse it.
> 
> 
> Diffs
> -----
> 
>   src/ksplittercollapserbutton.h PRE-CREATION 
>   src/ksplittercollapserbutton.cpp PRE-CREATION 
>   tests/CMakeLists.txt 5086ac0 
>   tests/ksplittercollapserbuttongui_test.h PRE-CREATION 
>   tests/ksplittercollapserbuttongui_test.cpp PRE-CREATION 
>   autotests/CMakeLists.txt 26c479f 
>   autotests/ksplittercollapserbuttontest.h PRE-CREATION 
>   autotests/ksplittercollapserbuttontest.cpp PRE-CREATION 
>   src/CMakeLists.txt 059d5d9 
> 
> Diff: https://git.reviewboard.kde.org/r/121145/diff/
> 
> 
> Testing
> -------
> 
> Created a lot of unittest.
> 
> I already done a lot of review code with David (thanks).
> 
> This widget can be show in kmail->compositor->snipset for example (in 4.14).
> 
> 
> Thanks,
> 
> Laurent Montel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141118/e932949f/attachment.html>


More information about the Kde-frameworks-devel mailing list