Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121145/
-----------------------------------------------------------

(Updated nov. 17, 2014, 4:48 après-midi)


Review request for KDE Frameworks, Christoph Feck and David Faure.


Changes
-------

Adapt code with Christoph comment.


Repository: kwidgetsaddons


Description
-------

This new widget adds a button on splitter to collapse it.


Diffs (updated)
-----

  src/ksplittercollapserbutton.h PRE-CREATION 
  src/ksplittercollapserbutton.cpp PRE-CREATION 
  tests/CMakeLists.txt 5086ac0 
  tests/ksplittercollapserbuttongui_test.h PRE-CREATION 
  tests/ksplittercollapserbuttongui_test.cpp PRE-CREATION 
  autotests/CMakeLists.txt 26c479f 
  autotests/ksplittercollapserbuttontest.h PRE-CREATION 
  autotests/ksplittercollapserbuttontest.cpp PRE-CREATION 
  src/CMakeLists.txt 059d5d9 

Diff: https://git.reviewboard.kde.org/r/121145/diff/


Testing
-------

Created a lot of unittest.

I already done a lot of review code with David (thanks).

This widget can be show in kmail->compositor->snipset for example (in 4.14).


Thanks,

Laurent Montel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141117/0a6f3866/attachment.html>