Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

Daniel Vrátil dvratil at redhat.com
Tue Nov 11 14:48:49 UTC 2014



> On Nov. 11, 2014, 3:39 p.m., Albert Astals Cid wrote:
> > I sincerely think this is a *VERY BAD* idea. I don't want my app behaving differently depending if a third party misterious compononent that is not documented anywhere is installed or not. If you have a dependency, well put it in a tier with direct access to that dependency, or put a huge warning in the docu saying this will lose the functionality if something else is not there.

This requirement is documented in ktexttohtml.h in /r/121094.

    /**
     * Replace text emoticons smileys by emoticons images.
     *
     * @note
     * This option works only when FrameworkIntegration plugin is installed,
     * and requires QGuiApplication. This will not work with QCoreApplication.
     * If the FrameworkIntegration plugin is not available, or this is called
     * from a QCoreApplication, this option will not do anything.
     */
    ReplaceSmileys  = 1 << 2,

The behaviour change in case the conditions above are not fulfiled are not drastical - the flag will simply be ignored. I don't see much difference over MessageBox not remembering "Don't show this again" between sessions, because it would be using only memory storage when FrameworkIntegrationPlugin is not installed (which btw is not documented at all)


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121095/#review70238
-----------------------------------------------------------


On Nov. 11, 2014, 1:12 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121095/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2014, 1:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> This patch is related to /r/121094, which moves KTextToHTML conversion utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on KEmoticons needed for smileys conversion, I added the actual KEmoticons code here, to create a run-time dependency, similar to the KWidgetsAddons-KConfig dependency for KMessageBox.
> 
> This patch refactors the FrameworkIntegrationPlugin a bit - I split the KMessageBox-specific code into a separate file, and added a new file with the KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking more and more classes into a single file :-)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3721bfa 
>   src/integrationplugin/CMakeLists.txt 3395368 
>   src/integrationplugin/frameworkintegrationplugin.h 6dc6825 
>   src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d 
>   src/integrationplugin/kmessagebox.h PRE-CREATION 
>   src/integrationplugin/kmessagebox.cpp PRE-CREATION 
>   src/integrationplugin/ktexttohtml.h PRE-CREATION 
>   src/integrationplugin/ktexttohtml.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121095/diff/
> 
> 
> Testing
> -------
> 
> Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems to work.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141111/2c751d64/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list