Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121095/#review70238
-----------------------------------------------------------


I sincerely think this is a *VERY BAD* idea. I don't want my app behaving differently depending if a third party misterious compononent that is not documented anywhere is installed or not. If you have a dependency, well put it in a tier with direct access to that dependency, or put a huge warning in the docu saying this will lose the functionality if something else is not there.

- Albert Astals Cid


On nov. 11, 2014, 12:12 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121095/
> -----------------------------------------------------------
> 
> (Updated nov. 11, 2014, 12:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> This patch is related to /r/121094, which moves KTextToHTML conversion utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on KEmoticons needed for smileys conversion, I added the actual KEmoticons code here, to create a run-time dependency, similar to the KWidgetsAddons-KConfig dependency for KMessageBox.
> 
> This patch refactors the FrameworkIntegrationPlugin a bit - I split the KMessageBox-specific code into a separate file, and added a new file with the KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking more and more classes into a single file :-)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3721bfa 
>   src/integrationplugin/CMakeLists.txt 3395368 
>   src/integrationplugin/frameworkintegrationplugin.h 6dc6825 
>   src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d 
>   src/integrationplugin/kmessagebox.h PRE-CREATION 
>   src/integrationplugin/kmessagebox.cpp PRE-CREATION 
>   src/integrationplugin/ktexttohtml.h PRE-CREATION 
>   src/integrationplugin/ktexttohtml.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121095/diff/
> 
> 
> Testing
> -------
> 
> Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems to work.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141111/982d4fad/attachment.html>