Review Request 120199: Implement KPluginTrader::query() using KPluginLoader::findPlugins()

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120199/#review69929
-----------------------------------------------------------



src/plugin/kplugintrader.cpp
<https://git.reviewboard.kde.org/r/120199/#comment48925>

    here and below, the conversions are costly just to check whether something is contained? rewrite this please:
    
        {
            const auto& types = md.serviceTypes();
            if (!types.isEmpty() && types.contains(serviceType)) {
                return true;
            }
        }
        const auto& data = md.rawData();
        {
            const auto& types = data.value(s_XKdeServiceTypes).toArray();
            if (!types.isEmpty() && types.contains(serviceType)) {
                return true;
            }
        }
        return data.value(s_serviceTypesKey).toArray().contains(serviceType);


- Milian Wolff


On Sept. 14, 2014, 2:06 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120199/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2014, 2:06 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Implement KPluginTrader::query() using KPluginLoader::findPlugins()
> 
> 
> Diffs
> -----
> 
>   src/plugin/kplugintrader.cpp 024d74ca5341a2960161b55e4efde956e80f7c76 
> 
> Diff: https://git.reviewboard.kde.org/r/120199/diff/
> 
> 
> Testing
> -------
> 
> Unit test still passes after applying RR 120198, not sure if it works without it.
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141106/17bf327f/attachment.html>