<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120199/">https://git.reviewboard.kde.org/r/120199/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120199/diff/1/?file=312121#file312121line98" style="color: black; font-weight: bold; text-decoration: underline;">src/plugin/kplugintrader.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KPluginTrader::applyConstraints(KPluginInfo::List &lst, const QString &constraint)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">96</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">QDir</span><span class="o">::</span><span class="n">isAbsolutePath</span><span class="p">(</span><span class="n">subDirectory</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">87</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">servicetypes</span> <span class="o">=</span> <span class="n">md</span><span class="p">.</span><span class="n">rawData</span><span class="p">().</span><span class="n">value</span><span class="p">(</span><span class="s">"X-KDE-ServiceTypes"</span><span class="p">).</span><span class="n">toVariant</span><span class="p">().</span><span class="n">toStringList</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">here and below, the conversions are costly just to check whether something is contained? rewrite this please:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">{
<span style="color: #008000; font-weight: bold">const</span> <span style="color: #008000; font-weight: bold">auto</span><span style="color: #666666">&</span> types <span style="color: #666666">=</span> md.serviceTypes();
<span style="color: #008000; font-weight: bold">if</span> (<span style="color: #666666">!</span>types.isEmpty() <span style="color: #666666">&&</span> types.contains(serviceType)) {
<span style="color: #008000; font-weight: bold">return</span> <span style="color: #008000">true</span>;
}
}
<span style="color: #008000; font-weight: bold">const</span> <span style="color: #008000; font-weight: bold">auto</span><span style="color: #666666">&</span> data <span style="color: #666666">=</span> md.rawData();
{
<span style="color: #008000; font-weight: bold">const</span> <span style="color: #008000; font-weight: bold">auto</span><span style="color: #666666">&</span> types <span style="color: #666666">=</span> data.value(s_XKdeServiceTypes).toArray();
<span style="color: #008000; font-weight: bold">if</span> (<span style="color: #666666">!</span>types.isEmpty() <span style="color: #666666">&&</span> types.contains(serviceType)) {
<span style="color: #008000; font-weight: bold">return</span> <span style="color: #008000">true</span>;
}
}
<span style="color: #008000; font-weight: bold">return</span> data.value(s_serviceTypesKey).toArray().contains(serviceType);
</pre></div>
</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On September 14th, 2014, 2:06 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2014, 2:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Implement KPluginTrader::query() using KPluginLoader::findPlugins()</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unit test still passes after applying RR 120198, not sure if it works without it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugin/kplugintrader.cpp <span style="color: grey">(024d74ca5341a2960161b55e4efde956e80f7c76)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120199/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>