Supporting MSVC2010 in ktexteditor framework

[Milian Wolff]

On Wednesday 05 November 2014 00:33:58 Nicolás Alvarez wrote:
> Hi all,
> 
> According to https://community.kde.org/Frameworks/C++11, KDE
> Frameworks support MSVC2010 and later versions. Since ktexteditor is
> part of KF5, it is supposed to work on MSVC2010. It currently doesn't;
> several unsupported C++11 features were introduced to the library in
> the past few months.
> 
> We really really need a Windows CI so that this is noticed early :(
> 
> The unsupported C++ features include:
> - brace initialization: Cursor x = {0,0}; or return {};
> - delegating constructors
> - range-based for loops
> - initializing class members inside the class declaration instead of
> doing it in the constructor: class Foo { int x=42; }; (N2756)
> - not specifying the return type of lambdas: auto f = []() { return 42; }
> 
> I attached the patch that makes ktexteditor build with MSVC2010,
> except for a unit test where there's WAY too many brace-init. In my
> opinion, the code looks cleaner with these C++11 features, ie. before
> the patch.
> 
> So, I hereby propose making an exception and bumping the minimum
> compiler version *for ktexteditor only* to MSVC2012. Opinions?

OK from my side, but I'd say Christoph and Dominik should have the last say. 
Note that KDevelop does the same. We want to have fun working on the project, 
and imo using C++11 is more important in that regard then supporting MSVC2010.

Bye

-- 
Milian Wolff
mail at milianw.de
http://milianw.de