Review Request 118102: Use all entries from a cert attribute instead of just using the first one

Rohan Garg rohangarg at kubuntu.org
Mon May 19 13:26:46 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118102/
-----------------------------------------------------------

(Updated May 19, 2014, 6:56 p.m.)


Review request for KDE Frameworks.


Changes
-------

Update as per suggestions


Repository: kio


Description
-------

Instead of just using the first value of a attribute, use all entries, seperated by a ','

Also drop KSslInfoDialog::launchConfig since it's not used internally anywhere ( atleast as far as I can tell ), not to mention that the slot won't work anyway since it calls a bogus KCM


Diffs (updated)
-----

  src/widgets/ksslcertificatebox.cpp 576acd0 
  src/widgets/ksslinfodialog.h 5280242 
  src/widgets/ksslinfodialog.cpp 33001f4 

Diff: https://git.reviewboard.kde.org/r/118102/diff/


Testing
-------

KCM SSL still works


Thanks,

Rohan Garg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140519/1d492d5f/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list