Review Request 118102: Use all entries from a cert attribute instead of just using the first one

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118102/#review58018
-----------------------------------------------------------


You probably want to .join(", ") with a space so it can wrap.

- David Edmundson


On May 12, 2014, 3:49 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118102/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 3:49 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Instead of just using the first value of a attribute, use all entries, seperated by a ','
> 
> Also drop KSslInfoDialog::launchConfig since it's not used internally anywhere ( atleast as far as I can tell ), not to mention that the slot won't work anyway since it calls a bogus KCM
> 
> 
> Diffs
> -----
> 
>   src/widgets/ksslinfodialog.h 5280242 
>   src/widgets/ksslinfodialog.cpp 33001f4 
>   src/widgets/ksslcertificatebox.cpp 576acd0 
> 
> Diff: https://git.reviewboard.kde.org/r/118102/diff/
> 
> 
> Testing
> -------
> 
> KCM SSL still works
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140515/eca120f0/attachment.html>