Review Request 118101: fixed windows build

[Patrick von Reth]

> On May 13, 2014, 11:32 a.m., Alexander Richardson wrote:
> > autotests/ktimezonestest.cpp, line 303
> > <https://git.reviewboard.kde.org/r/118101/diff/1/?file=272606#file272606line303>
> >
> >     Seems this is always defined to 0 or 1, maybe just use HAVE_TM_GMTOFF?

yes but with this test I can be sure it works in both cases.


- Patrick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118101/#review57867
-----------------------------------------------------------


On May 12, 2014, 3:43 p.m., Patrick von Reth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118101/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 3:43 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> -------
> 
> Fixed the Windows build.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7c4a2328a43c42fd830b4048608ad5a651565ace 
>   autotests/kiotesthelper.h 6b231a32d6b5d166e86de832e8028f4cc6a1fc2a 
>   autotests/ktimezonestest.cpp 9693287fde17fdc8c0b01bdf2071e020c047c339 
>   src/CMakeLists.txt 4a118a4e750fd1a7516d9fdf76a368085f81f811 
>   src/ConfigureChecks.cmake d8ece7ba778767f35a533cfa6b34417caddaa5f1 
>   src/kdecore/kdebug.h fe7aeecae345cab2ea31e9419e176e37a05641ae 
>   src/kdecore/kdebug.cpp 60fdca4e5a237d8a96da7cf0bace0ad4a47b476b 
>   src/kdecore/kkernel_win.cpp e9e8be2307650c4f6142cd2cb052e64bf7ab78f6 
>   src/kdecore/kmimetype.cpp 4002423ba47a9b6134154a67a008b68f0e54d2dc 
>   src/kdecore/ksavefile.cpp a13530f210c4aa7d2f0afc88ace394c9298d2b97 
>   src/kdecore/ksystemtimezone.cpp b117b15d1c10e7c06a32253842c88cfa3366dc26 
>   src/kdecore/ktempdir.cpp 775419bc2ef36db84c1464c6ee643971d42b3e79 
>   src/kdecore/ktimezone_win.cpp 4765d30284ef7a27f988c0fa0cb8fed09781f8f8 
>   src/kdecore/netsupp.h 1af71c19f6d15f1169fef087aeb57194c72a2a75 
>   src/kdecore/netsupp.cpp add1a6fa0adc58fcb3f17faf0180e3c1fedbdf8f 
>   src/kdeui/kapplication_win.cpp c555406cb9a5a060457e87e1b6b839f10abf4e41 
>   src/kdeui/kpixmapcache.cpp 198a37eb1ccec3fa521181e389dcd3feb043de18 
>   src/kio/kdirselectdialog.cpp 515001d4df91a0bef21dea8a09ab75e8e8ffa716 
>   src/kio/kfiledialog.cpp 90c42ffef9bc86a96c307f920a6e8e6a1d436516 
>   src/solid/networking_win.cpp ec16cde8fa8fe1aabb94d5ac6fdebbc17a32b993 
>   tests/CMakeLists.txt 1297013f7afc933dbc6ff7458601a6c7802c0658 
> 
> Diff: https://git.reviewboard.kde.org/r/118101/diff/
> 
> 
> Testing
> -------
> 
> Windows mingw
> 
> 
> Thanks,
> 
> Patrick von Reth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140513/9a7f09c0/attachment-0001.html>