<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118101/">https://git.reviewboard.kde.org/r/118101/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 13th, 2014, 11:32 a.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118101/diff/1/?file=272606#file272606line303" style="color: black; font-weight: bold; text-decoration: underline;">autotests/ktimezonestest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KTimeZonesTest::currentOffset()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">303</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#if defined(HAVE_TM_GMTOFF)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">303</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#if defined(HAVE_TM_GMTOFF)<span class="hl"> && HAVE_TM_GMTOFF</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems this is always defined to 0 or 1, maybe just use HAVE_TM_GMTOFF?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes but with this test I can be sure it works in both cases.</pre>
<br />
<p>- Patrick</p>
<br />
<p>On May 12th, 2014, 3:43 p.m. UTC, Patrick von Reth wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and kdewin.</div>
<div>By Patrick von Reth.</div>
<p style="color: grey;"><i>Updated May 12, 2014, 3:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed the Windows build.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Windows mingw</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(7c4a2328a43c42fd830b4048608ad5a651565ace)</span></li>
<li>autotests/kiotesthelper.h <span style="color: grey">(6b231a32d6b5d166e86de832e8028f4cc6a1fc2a)</span></li>
<li>autotests/ktimezonestest.cpp <span style="color: grey">(9693287fde17fdc8c0b01bdf2071e020c047c339)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(4a118a4e750fd1a7516d9fdf76a368085f81f811)</span></li>
<li>src/ConfigureChecks.cmake <span style="color: grey">(d8ece7ba778767f35a533cfa6b34417caddaa5f1)</span></li>
<li>src/kdecore/kdebug.h <span style="color: grey">(fe7aeecae345cab2ea31e9419e176e37a05641ae)</span></li>
<li>src/kdecore/kdebug.cpp <span style="color: grey">(60fdca4e5a237d8a96da7cf0bace0ad4a47b476b)</span></li>
<li>src/kdecore/kkernel_win.cpp <span style="color: grey">(e9e8be2307650c4f6142cd2cb052e64bf7ab78f6)</span></li>
<li>src/kdecore/kmimetype.cpp <span style="color: grey">(4002423ba47a9b6134154a67a008b68f0e54d2dc)</span></li>
<li>src/kdecore/ksavefile.cpp <span style="color: grey">(a13530f210c4aa7d2f0afc88ace394c9298d2b97)</span></li>
<li>src/kdecore/ksystemtimezone.cpp <span style="color: grey">(b117b15d1c10e7c06a32253842c88cfa3366dc26)</span></li>
<li>src/kdecore/ktempdir.cpp <span style="color: grey">(775419bc2ef36db84c1464c6ee643971d42b3e79)</span></li>
<li>src/kdecore/ktimezone_win.cpp <span style="color: grey">(4765d30284ef7a27f988c0fa0cb8fed09781f8f8)</span></li>
<li>src/kdecore/netsupp.h <span style="color: grey">(1af71c19f6d15f1169fef087aeb57194c72a2a75)</span></li>
<li>src/kdecore/netsupp.cpp <span style="color: grey">(add1a6fa0adc58fcb3f17faf0180e3c1fedbdf8f)</span></li>
<li>src/kdeui/kapplication_win.cpp <span style="color: grey">(c555406cb9a5a060457e87e1b6b839f10abf4e41)</span></li>
<li>src/kdeui/kpixmapcache.cpp <span style="color: grey">(198a37eb1ccec3fa521181e389dcd3feb043de18)</span></li>
<li>src/kio/kdirselectdialog.cpp <span style="color: grey">(515001d4df91a0bef21dea8a09ab75e8e8ffa716)</span></li>
<li>src/kio/kfiledialog.cpp <span style="color: grey">(90c42ffef9bc86a96c307f920a6e8e6a1d436516)</span></li>
<li>src/solid/networking_win.cpp <span style="color: grey">(ec16cde8fa8fe1aabb94d5ac6fdebbc17a32b993)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(1297013f7afc933dbc6ff7458601a6c7802c0658)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118101/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>