Review Request 118082: Remove KUrlNavigator tests for ~ and ~username

[David Faure]

> On May 11, 2014, 2:30 p.m., Alexander Richardson wrote:
> > KUrlNavigator effectively depends on kshorturifilter and kurisearchfilter, wouldn't it make sense to have them with kurlnavigator?
> > 
> > see line 972 of kurlnavigator.cpp: if (KUriFilter::self()->filterUri(filteredData, QStringList() << "kshorturifilter" << "kurisearchfilter")) {
> >
> 
> Alex Merry wrote:
>     Well, in that case, the correct solution is to ship those plugins with kio instead of kio-extras. I can do that move (and preserve the history) if you like, and David is happy with that.
> 
> Alexander Richardson wrote:
>     I ported all the kurifilter plugins away from kdelibs4support and AFAIK they don't add any new dependencies to KIO, so I think they should go there.
> 
> David Faure wrote:
>     Hmm, interesting point. It's an optional runtime dependency: if you wanted to get a "as small as possible kio, just to download stuff over, say, sftp" then you wouldn't need that.
>     Things work without it, just without some short-typing features in url bars.
>     On the other hand, if they bring no dependency I guess we can have the uri filter plugins in kio as well. It's not like it's small in the first place :)
>     
>     => OK then, please move the uri filters to kio.
> 
> Alex Merry wrote:
>     All of the ones in kio-extras? There are four: kshorturifilter, kurisearchfilter, fixhosturifilter (looks up hosts and tries prepending "www.") and localdomainurifilter (not sure what the "local" refers to, but appears to try prepending "http://" when no protocol is given).

localdomain because it resolves hostnames on your local domain, e.g. if you have a machine called startrek and you type startrek in the location bar, it'll become http://startrek

Yes, let's move the four of them, the ones kio depends on are the two big ones, the other two are very small, we might as well keep them together.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118082/#review57717
-----------------------------------------------------------


On May 11, 2014, 2:34 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118082/
> -----------------------------------------------------------
> 
> (Updated May 11, 2014, 2:34 p.m.)
> 
> 
> Review request for KDE Frameworks, Alexander Richardson and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Remove KUrlNavigator tests for ~ and ~username
> 
> These depended on a KUriFilter plugin shipped with kio-extras, which
> meant the test would fail if that was not installed.
> 
> A better approach to this test might be to provide a fake kurifilter
> plugin (and use it to test KUriFilter directly), and check that it works
> via KUrlNavigator as well.
> 
> 
> Diffs
> -----
> 
>   autotests/kurlnavigatortest.cpp e09944a89c7d2b3ed341003de1bd02ea75293758 
> 
> Diff: https://git.reviewboard.kde.org/r/118082/diff/
> 
> 
> Testing
> -------
> 
> The kiowidgets-kurlnavigator test now passes without kio-extras installed.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140512/fcb8ad19/attachment-0001.html>