<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118082/">https://git.reviewboard.kde.org/r/118082/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 11th, 2014, 2:30 p.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KUrlNavigator effectively depends on kshorturifilter and kurisearchfilter, wouldn't it make sense to have them with kurlnavigator?
see line 972 of kurlnavigator.cpp: if (KUriFilter::self()->filterUri(filteredData, QStringList() << "kshorturifilter" << "kurisearchfilter")) {
</pre>
</blockquote>
<p>On May 11th, 2014, 2:34 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, in that case, the correct solution is to ship those plugins with kio instead of kio-extras. I can do that move (and preserve the history) if you like, and David is happy with that.</pre>
</blockquote>
<p>On May 11th, 2014, 2:59 p.m. UTC, <b>Alexander Richardson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I ported all the kurifilter plugins away from kdelibs4support and AFAIK they don't add any new dependencies to KIO, so I think they should go there.</pre>
</blockquote>
<p>On May 12th, 2014, 7:24 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, interesting point. It's an optional runtime dependency: if you wanted to get a "as small as possible kio, just to download stuff over, say, sftp" then you wouldn't need that.
Things work without it, just without some short-typing features in url bars.
On the other hand, if they bring no dependency I guess we can have the uri filter plugins in kio as well. It's not like it's small in the first place :)
=> OK then, please move the uri filters to kio.</pre>
</blockquote>
<p>On May 12th, 2014, 12:18 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All of the ones in kio-extras? There are four: kshorturifilter, kurisearchfilter, fixhosturifilter (looks up hosts and tries prepending "www.") and localdomainurifilter (not sure what the "local" refers to, but appears to try prepending "http://" when no protocol is given).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">localdomain because it resolves hostnames on your local domain, e.g. if you have a machine called startrek and you type startrek in the location bar, it'll become http://startrek
Yes, let's move the four of them, the ones kio depends on are the two big ones, the other two are very small, we might as well keep them together.</pre>
<br />
<p>- David</p>
<br />
<p>On May 11th, 2014, 2:34 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Alexander Richardson and David Faure.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated May 11, 2014, 2:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove KUrlNavigator tests for ~ and ~username
These depended on a KUriFilter plugin shipped with kio-extras, which
meant the test would fail if that was not installed.
A better approach to this test might be to provide a fake kurifilter
plugin (and use it to test KUriFilter directly), and check that it works
via KUrlNavigator as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The kiowidgets-kurlnavigator test now passes without kio-extras installed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kurlnavigatortest.cpp <span style="color: grey">(e09944a89c7d2b3ed341003de1bd02ea75293758)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118082/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>